Skip to content

refactor(events): use vim.defaulttable in EventManager #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

refactor(events): use vim.defaulttable in EventManager #886

merged 2 commits into from
Feb 3, 2025

Conversation

broken-pen
Copy link
Contributor

Summary

Minor clean-up of EventManager by using vim.defaulttable instead of custom logic.

Related Issues

Extracted from #878

Changes

  • fix a minor type issue in EventManager.init
  • replace custom logic in EventManager.listen with vim.defaulttable

Checklist

I confirm that I have:

  • Followed the Conventional Commits specification (e.g., feat: add new feature, fix: correct bug, docs: update documentation).
  • My PR title also follows the conventional commits specification.
  • Updated relevant documentation, if necessary.
  • Thoroughly tested my changes.
  • Added tests (if applicable) and verified existing tests pass with make test.
  • Checked for breaking changes and documented them, if any.

@kristijanhusak kristijanhusak merged commit 535701d into nvim-orgmode:master Feb 3, 2025
6 checks passed
@broken-pen broken-pen deleted the fix/event-manager-init branch February 3, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristijanhusak kristijanhusak kristijanhusak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@broken-pen @kristijanhusak